Make daemonset mountPropagation configurable, remove bidirectional default #180
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlubins
force-pushed
the
remove-bidirectional-mount-propagation-default
branch
from
f745fcd to
0f815c8
Compare
added 2 commits
January 6, 2026 08:44
…fault Signed-off-by: John Lubinski <[email protected]>
Signed-off-by: John Lubinski <[email protected]>
jlubins
force-pushed
the
remove-bidirectional-mount-propagation-default
branch
from
19a18a9 to
31cd748
Compare
Author
|
Hi @No9, when you have a chance, could I trouble you to review this PR? It has seemingly bitten several users in the past, and prevents me from safely using core-dump-handler in quite a few places. |
Collaborator
|
@jlubins the lint is failing - can you update the PR to resolve this and I can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues #119 and #154 where the core-dump-handler causes excessive bind mounts due to bidirectional mount propagation. When pods restart frequently (e.g., due to memory limits being set too low), this has potential to create thousands of duplicate bind mounts, leading to:
The current implementation hardcodes mountPropagation: Bidirectional in the DaemonSet template. As noted in the Kubernetes documentation (see warning), bidirectional mount propagation can be dangerous and requires containers to properly clean up mounts on termination. Each pod restart doubles the number of mounts, quickly reaching system limits.
This PR makes mountPropagation configurable via Helm values and removes the bidirectional default. Users can now: